From a9622f38cc4c4f2cebb1c2f99722efb455cf6812 Mon Sep 17 00:00:00 2001 From: Jon Miranda Date: Thu, 2 May 2019 08:55:38 -0700 Subject: [PATCH] Remove shortcuts/deepshortcuts as targets for swipe up to icon animation. We'll add it back when b/129067201 is fixed. Bug: 131809649 Change-Id: I6f009a84b86717f86394da6fb8540eb3f226419a --- src/com/android/launcher3/Workspace.java | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/src/com/android/launcher3/Workspace.java b/src/com/android/launcher3/Workspace.java index aa09173103..f1c183bb4c 100644 --- a/src/com/android/launcher3/Workspace.java +++ b/src/com/android/launcher3/Workspace.java @@ -2907,14 +2907,11 @@ public class Workspace extends PagedView && info.user.equals(user); final Workspace.ItemOperator packageAndUserAndApp = (ItemInfo info, View view) -> packageAndUser.evaluate(info, view) && info.itemType == ITEM_TYPE_APPLICATION; - final Workspace.ItemOperator packageAndUserAndShortcut = (ItemInfo info, View view) -> - packageAndUser.evaluate(info, view) && (info.itemType == ITEM_TYPE_SHORTCUT - || info.itemType == ITEM_TYPE_DEEP_SHORTCUT); - final Workspace.ItemOperator packageAndUserInFolder = (info, view) -> { + final Workspace.ItemOperator packageAndUserAndAppInFolder = (info, view) -> { if (info instanceof FolderInfo) { FolderInfo folderInfo = (FolderInfo) info; for (WorkspaceItemInfo shortcutInfo : folderInfo.contents) { - if (packageAndUser.evaluate(shortcutInfo, view)) { + if (packageAndUserAndApp.evaluate(shortcutInfo, view)) { return true; } } @@ -2922,15 +2919,15 @@ public class Workspace extends PagedView return false; }; - // Order: App icons, shortcuts, app/shortcut in folder. Items in hotseat get returned first. + // Order: App icons, app in folder. Items in hotseat get returned first. if (ADAPTIVE_ICON_WINDOW_ANIM.get()) { return getFirstMatch(new CellLayout[] { getHotseat(), currentPage }, - packageAndUserAndApp, packageAndUserAndShortcut, packageAndUserInFolder); + packageAndUserAndApp, packageAndUserAndAppInFolder); } else { // Do not use Folder as a criteria, since it'll cause a crash when trying to draw // FolderAdaptiveIcon as the background. return getFirstMatch(new CellLayout[] { getHotseat(), currentPage }, - packageAndUserAndApp, packageAndUserAndShortcut); + packageAndUserAndApp); } }