From a8109fb98cb36cd221f86a12de2cb6d296261533 Mon Sep 17 00:00:00 2001 From: Jon Miranda Date: Wed, 30 Oct 2019 09:56:44 -0700 Subject: [PATCH] Fix bug where Files app keeps getting added to the workspace. Caused by mainline updates where Files app session commit is broadcasted. Launcher workaround is to not auto-add system apps to the workspace. Bug: 139663018 Change-Id: Id61532bd0df2cd5f3bdfc28a3616ba5e5ff3d18a --- src/com/android/launcher3/model/AddWorkspaceItemsTask.java | 5 +++++ src/com/android/launcher3/util/PackageManagerHelper.java | 3 +++ 2 files changed, 8 insertions(+) diff --git a/src/com/android/launcher3/model/AddWorkspaceItemsTask.java b/src/com/android/launcher3/model/AddWorkspaceItemsTask.java index 1b98783a74..37f28a9a2f 100644 --- a/src/com/android/launcher3/model/AddWorkspaceItemsTask.java +++ b/src/com/android/launcher3/model/AddWorkspaceItemsTask.java @@ -76,6 +76,11 @@ public class AddWorkspaceItemsTask extends BaseModelUpdateTask { if (shortcutExists(dataModel, item.getIntent(), item.user)) { continue; } + + // b/139663018 Short-circuit this logic if the icon is a system app + if (PackageManagerHelper.isSystemApp(app.getContext(), item.getIntent())) { + continue; + } } if (item.itemType == LauncherSettings.Favorites.ITEM_TYPE_APPLICATION) { diff --git a/src/com/android/launcher3/util/PackageManagerHelper.java b/src/com/android/launcher3/util/PackageManagerHelper.java index ef4307ec59..e97adb5771 100644 --- a/src/com/android/launcher3/util/PackageManagerHelper.java +++ b/src/com/android/launcher3/util/PackageManagerHelper.java @@ -236,6 +236,9 @@ public class PackageManagerHelper { } else { packageName = cn.getPackageName(); } + if (packageName == null) { + packageName = intent.getPackage(); + } if (packageName != null) { try { PackageInfo info = pm.getPackageInfo(packageName, 0);