From b620af4612f7fd2806965be41c13b916cd97649e Mon Sep 17 00:00:00 2001 From: Vinit Nayak Date: Mon, 21 Aug 2023 23:40:51 +0000 Subject: [PATCH] Null out Activity in split controller Bug: 295225524 Change-Id: I59aaed3fca07d611088cec0a4bfafc658a151bb2 --- .../android/launcher3/uioverrides/QuickstepLauncher.java | 4 ++++ quickstep/src/com/android/quickstep/RecentsActivity.java | 2 +- .../android/quickstep/util/SplitSelectStateController.java | 6 +++++- 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/quickstep/src/com/android/launcher3/uioverrides/QuickstepLauncher.java b/quickstep/src/com/android/launcher3/uioverrides/QuickstepLauncher.java index d74a13b40f..b736ed8c4c 100644 --- a/quickstep/src/com/android/launcher3/uioverrides/QuickstepLauncher.java +++ b/quickstep/src/com/android/launcher3/uioverrides/QuickstepLauncher.java @@ -482,6 +482,10 @@ public class QuickstepLauncher extends Launcher { mDesktopVisibilityController.unregisterSystemUiListener(); } + if (mSplitSelectStateController != null) { + mSplitSelectStateController.onDestroy(); + } + super.onDestroy(); mHotseatPredictionController.destroy(); mSplitWithKeyboardShortcutController.onDestroy(); diff --git a/quickstep/src/com/android/quickstep/RecentsActivity.java b/quickstep/src/com/android/quickstep/RecentsActivity.java index 2e1a62c372..1d2902cbc8 100644 --- a/quickstep/src/com/android/quickstep/RecentsActivity.java +++ b/quickstep/src/com/android/quickstep/RecentsActivity.java @@ -393,7 +393,7 @@ public final class RecentsActivity extends StatefulActivity { super.onDestroy(); ACTIVITY_TRACKER.onActivityDestroyed(this); mActivityLaunchAnimationRunner = null; - + mSplitSelectStateController.onDestroy(); mTISBindHelper.onDestroy(); } diff --git a/quickstep/src/com/android/quickstep/util/SplitSelectStateController.java b/quickstep/src/com/android/quickstep/util/SplitSelectStateController.java index 0c897663f5..6d5aa169ab 100644 --- a/quickstep/src/com/android/quickstep/util/SplitSelectStateController.java +++ b/quickstep/src/com/android/quickstep/util/SplitSelectStateController.java @@ -113,7 +113,7 @@ import java.util.function.Consumer; public class SplitSelectStateController { private static final String TAG = "SplitSelectStateCtor"; - private final Context mContext; + private Context mContext; private final Handler mHandler; private final RecentsModel mRecentTasksModel; private final SplitAnimationController mSplitAnimationController; @@ -157,6 +157,10 @@ public class SplitSelectStateController { mSplitSelectDataHolder = new SplitSelectDataHolder(mContext); } + public void onDestroy() { + mContext = null; + } + /** * @param alreadyRunningTask if set to {@link android.app.ActivityTaskManager#INVALID_TASK_ID} * then @param intent will be used to launch the initial task