From 1c5ddff010dd22a549ed2f1dae84e0ae96cffd27 Mon Sep 17 00:00:00 2001 From: Cyrus Boadway Date: Fri, 7 May 2021 09:23:45 +0000 Subject: [PATCH] Remove widget launch CUJ from jank monitoring The widget launch animation should not be measured with the icon launch animations. No widget launch CUJ yet exists, so no jank monitoring should be applied to widget app launches. Bug: 169042867 Test: manual Change-Id: I2a525c42cca8dd17c4a96bde7f11b14cfe87cabc --- .../android/launcher3/QuickstepTransitionManager.java | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/quickstep/src/com/android/launcher3/QuickstepTransitionManager.java b/quickstep/src/com/android/launcher3/QuickstepTransitionManager.java index 36764a1519..14382d6f09 100644 --- a/quickstep/src/com/android/launcher3/QuickstepTransitionManager.java +++ b/quickstep/src/com/android/launcher3/QuickstepTransitionManager.java @@ -1260,21 +1260,20 @@ public class QuickstepTransitionManager implements OnDeviceProfileChangeListener if (launchingFromWidget) { composeWidgetLaunchAnimator(anim, (LauncherAppWidgetHostView) mV, appTargets, wallpaperTargets, nonAppTargets); + // TODO(b/169042867): jank monitoring instrumentation } else if (launchingFromRecents) { composeRecentsLaunchAnimator(anim, mV, appTargets, wallpaperTargets, nonAppTargets, launcherClosing); + addCujInstrumentation( + anim, InteractionJankMonitorWrapper.CUJ_APP_LAUNCH_FROM_RECENTS); } else if (launchingFromTaskbar) { // TODO } else { composeIconLaunchAnimator(anim, mV, appTargets, wallpaperTargets, nonAppTargets, launcherClosing); + addCujInstrumentation(anim, InteractionJankMonitorWrapper.CUJ_APP_LAUNCH_FROM_ICON); } - addCujInstrumentation(anim, - launchingFromRecents - ? InteractionJankMonitorWrapper.CUJ_APP_LAUNCH_FROM_RECENTS - : InteractionJankMonitorWrapper.CUJ_APP_LAUNCH_FROM_ICON); - if (launcherClosing) { anim.addListener(mForceInvisibleListener); }