From 7a2cea6b8a629c4f46d052d26ef3aed3ed3ff131 Mon Sep 17 00:00:00 2001 From: Vinit Nayak Date: Mon, 28 Aug 2023 22:44:08 +0000 Subject: [PATCH] Cleanup logs for LAUNCH_SPLIT_PAIR Fixes: 288939273 Change-Id: I39624ce0ba9951bdea7691545268cdc369d1c606 --- quickstep/src/com/android/quickstep/TaskViewUtils.java | 4 ---- .../android/quickstep/util/SplitSelectStateController.java | 5 +---- .../com/android/launcher3/testing/shared/TestProtocol.java | 3 +-- 3 files changed, 2 insertions(+), 10 deletions(-) diff --git a/quickstep/src/com/android/quickstep/TaskViewUtils.java b/quickstep/src/com/android/quickstep/TaskViewUtils.java index af49774061..97e484a71a 100644 --- a/quickstep/src/com/android/quickstep/TaskViewUtils.java +++ b/quickstep/src/com/android/quickstep/TaskViewUtils.java @@ -38,8 +38,6 @@ import static com.android.launcher3.QuickstepTransitionManager.RECENTS_LAUNCH_DU import static com.android.launcher3.QuickstepTransitionManager.SPLIT_DIVIDER_ANIM_DURATION; import static com.android.launcher3.QuickstepTransitionManager.SPLIT_LAUNCH_DURATION; import static com.android.launcher3.Utilities.getDescendantCoordRelativeToAncestor; -import static com.android.launcher3.testing.shared.TestProtocol.LAUNCH_SPLIT_PAIR; -import static com.android.launcher3.testing.shared.TestProtocol.testLogD; import static com.android.launcher3.util.MultiPropertyFactory.MULTI_PROPERTY_VALUE; import static com.android.quickstep.views.DesktopTaskView.DESKTOP_MODE_SUPPORTED; @@ -427,7 +425,6 @@ public final class TaskViewUtils { int initialTaskId, int secondTaskId, @NonNull TransitionInfo transitionInfo, SurfaceControl.Transaction t, @NonNull Runnable finishCallback) { if (launchingTaskView != null) { - testLogD(LAUNCH_SPLIT_PAIR, "composeRecentsSplitLaunchAnimator taskView not-null"); AnimatorSet animatorSet = new AnimatorSet(); animatorSet.addListener(new AnimatorListenerAdapter() { @Override @@ -461,7 +458,6 @@ public final class TaskViewUtils { for (int i = 0; i < transitionInfo.getChanges().size(); ++i) { final TransitionInfo.Change change = transitionInfo.getChanges().get(i); if (change.getTaskInfo() == null) { - testLogD(LAUNCH_SPLIT_PAIR, "changeTaskInfo null; change: " + change); continue; } final int taskId = change.getTaskInfo().taskId; diff --git a/quickstep/src/com/android/quickstep/util/SplitSelectStateController.java b/quickstep/src/com/android/quickstep/util/SplitSelectStateController.java index 6d5aa169ab..8df0c18bc5 100644 --- a/quickstep/src/com/android/quickstep/util/SplitSelectStateController.java +++ b/quickstep/src/com/android/quickstep/util/SplitSelectStateController.java @@ -19,8 +19,6 @@ package com.android.quickstep.util; import static com.android.launcher3.Utilities.postAsyncCallback; import static com.android.launcher3.config.FeatureFlags.ENABLE_SPLIT_FROM_DESKTOP_TO_WORKSPACE; import static com.android.launcher3.logging.StatsLogManager.LauncherEvent.LAUNCHER_DESKTOP_MODE_SPLIT_RIGHT_BOTTOM; -import static com.android.launcher3.testing.shared.TestProtocol.LAUNCH_SPLIT_PAIR; -import static com.android.launcher3.testing.shared.TestProtocol.testLogD; import static com.android.launcher3.util.Executors.MAIN_EXECUTOR; import static com.android.launcher3.util.Executors.UI_HELPER_EXECUTOR; import static com.android.launcher3.util.SplitConfigurationOptions.DEFAULT_SPLIT_RATIO; @@ -93,8 +91,8 @@ import com.android.quickstep.TaskAnimationManager; import com.android.quickstep.TaskViewUtils; import com.android.quickstep.views.FloatingTaskView; import com.android.quickstep.views.GroupedTaskView; -import com.android.quickstep.views.SplitInstructionsView; import com.android.quickstep.views.RecentsView; +import com.android.quickstep.views.SplitInstructionsView; import com.android.systemui.shared.recents.model.Task; import com.android.systemui.shared.system.ActivityManagerWrapper; import com.android.systemui.shared.system.RemoteAnimationRunnerCompat; @@ -580,7 +578,6 @@ public class SplitSelectStateController { public void startAnimation(IBinder transition, TransitionInfo info, SurfaceControl.Transaction t, IRemoteTransitionFinishedCallback finishedCallback) { - testLogD(LAUNCH_SPLIT_PAIR, "Received split startAnimation"); final Runnable finishAdapter = () -> { try { finishedCallback.onTransitionFinished(null /* wct */, null /* sct */); diff --git a/tests/shared/com/android/launcher3/testing/shared/TestProtocol.java b/tests/shared/com/android/launcher3/testing/shared/TestProtocol.java index 87ec2600ea..1d3d91e9f8 100644 --- a/tests/shared/com/android/launcher3/testing/shared/TestProtocol.java +++ b/tests/shared/com/android/launcher3/testing/shared/TestProtocol.java @@ -158,10 +158,9 @@ public final class TestProtocol { public static final String FLAKY_ACTIVITY_COUNT = "b/260260325"; public static final String FLAKY_QUICK_SWITCH_TO_PREVIOUS_APP = "b/286084688"; public static final String ICON_MISSING = "b/282963545"; - public static final String LAUNCH_SPLIT_PAIR = "b/288939273"; - public static final String OVERVIEW_OVER_HOME = "b/279059025"; public static final String INCORRECT_HOME_STATE = "b/293191790"; + public static final String REQUEST_EMULATE_DISPLAY = "emulate-display"; public static final String REQUEST_STOP_EMULATE_DISPLAY = "stop-emulate-display"; public static final String REQUEST_IS_EMULATE_DISPLAY_RUNNING = "is-emulate-display-running";