From 45b33a1a55d66e35d5239e1940ebc5721bbc9e24 Mon Sep 17 00:00:00 2001
From: Ikram Gabiyev <gabiyev@google.com>
Date: Wed, 24 May 2023 13:29:01 -0700
Subject: [PATCH] Remove contentDescription attribute in filter icon

Remove contentDescription attribute for multi-instance
filter icon ImageView since importantForAccessibility="no"
to avoid talkback noting it instead of the task name itself.

Bug: 280908761
Test: manually reproduce the steps in the bug
Change-Id: Ifdc884537222565fc2e52d5a17272f19a4446f62
---
 quickstep/res/layout/task.xml         | 1 -
 quickstep/res/layout/task_grouped.xml | 2 --
 quickstep/res/values/strings.xml      | 4 ----
 3 files changed, 7 deletions(-)

diff --git a/quickstep/res/layout/task.xml b/quickstep/res/layout/task.xml
index e981730710..4865aef5af 100644
--- a/quickstep/res/layout/task.xml
+++ b/quickstep/res/layout/task.xml
@@ -40,7 +40,6 @@
         android:layout_gravity="end"
         android:alpha="0"
         android:tint="@color/recents_filter_icon"
-        android:contentDescription="@string/recents_filter_icon_desc"
         android:importantForAccessibility="no"
         android:src="@drawable/ic_select_windows" />
 
diff --git a/quickstep/res/layout/task_grouped.xml b/quickstep/res/layout/task_grouped.xml
index 65febba6b7..c9fa9c07aa 100644
--- a/quickstep/res/layout/task_grouped.xml
+++ b/quickstep/res/layout/task_grouped.xml
@@ -50,7 +50,6 @@
         android:layout_gravity="start"
         android:alpha="0"
         android:tint="@color/recents_filter_icon"
-        android:contentDescription="@string/recents_filter_icon_desc"
         android:importantForAccessibility="no"
         android:src="@drawable/ic_select_windows" />
 
@@ -63,7 +62,6 @@
         android:layout_gravity="end"
         android:alpha="0"
         android:tint="@color/recents_filter_icon"
-        android:contentDescription="@string/recents_filter_icon_desc"
         android:importantForAccessibility="no"
         android:src="@drawable/ic_select_windows" />
 
diff --git a/quickstep/res/values/strings.xml b/quickstep/res/values/strings.xml
index 2d8c45a4dc..bd69f9f4ec 100644
--- a/quickstep/res/values/strings.xml
+++ b/quickstep/res/values/strings.xml
@@ -39,10 +39,6 @@
     <!-- Recents: Title of a button that goes back from displaying tasks filtered by package name to displaying all tasks [CHAR LIMIT=30] -->
     <string name="recents_back" translatable="false">Back</string>
 
-    <!-- TODO: b/260610444. Content description of filtering icons needs to be updated -->
-    <!-- Recents: Content description for the icon on top of taskviews to initiate filtering -->
-    <string name="recents_filter_icon_desc" translatable="false">Click to show only this app\'s tasks</string>
-
     <!-- Accessibility title for the list of recent apps [CHAR_LIMIT=none] -->
     <string name="accessibility_recent_apps">Recent apps</string>