From 58ffbef8f0a9a71d4aa264e0af0cdecab1fddd50 Mon Sep 17 00:00:00 2001 From: Vinit Nayak Date: Tue, 15 Jun 2021 13:14:41 -0700 Subject: [PATCH] Enable 3 button nav for taskbar Bug: 180046394 Test: Switched between gesture and button nav on phone and tablet. Change-Id: Iac2357a3256f8b6b36ca49d3680594a91e824a5f --- .../launcher3/taskbar/NavbarButtonsViewController.java | 2 +- .../android/launcher3/taskbar/TaskbarActivityContext.java | 6 +++--- .../com/android/launcher3/taskbar/TaskbarControllers.java | 2 +- .../launcher3/taskbar/TaskbarDragLayerController.java | 2 +- .../launcher3/taskbar/TaskbarKeyguardController.java | 2 +- 5 files changed, 7 insertions(+), 7 deletions(-) diff --git a/quickstep/src/com/android/launcher3/taskbar/NavbarButtonsViewController.java b/quickstep/src/com/android/launcher3/taskbar/NavbarButtonsViewController.java index d40242c42c..2facd4436c 100644 --- a/quickstep/src/com/android/launcher3/taskbar/NavbarButtonsViewController.java +++ b/quickstep/src/com/android/launcher3/taskbar/NavbarButtonsViewController.java @@ -105,7 +105,7 @@ public class NavbarButtonsViewController { return true; }; - if (mContext.canShowNavButtons()) { + if (mContext.isThreeButtonNav()) { initButtons(mStartContainer, mEndContainer, mControllers.navButtonController); // Animate taskbar background when IME shows diff --git a/quickstep/src/com/android/launcher3/taskbar/TaskbarActivityContext.java b/quickstep/src/com/android/launcher3/taskbar/TaskbarActivityContext.java index 000799b73b..59586abee7 100644 --- a/quickstep/src/com/android/launcher3/taskbar/TaskbarActivityContext.java +++ b/quickstep/src/com/android/launcher3/taskbar/TaskbarActivityContext.java @@ -161,8 +161,8 @@ public class TaskbarActivityContext extends ContextThemeWrapper implements Activ mWindowManager.addView(mDragLayer, mWindowLayoutParams); } - public boolean canShowNavButtons() { - return ENABLE_THREE_BUTTON_TASKBAR && mNavMode == Mode.THREE_BUTTONS; + public boolean isThreeButtonNav() { + return mNavMode == Mode.THREE_BUTTONS; } @Override @@ -214,7 +214,7 @@ public class TaskbarActivityContext extends ContextThemeWrapper implements Activ } public void updateSysuiStateFlags(int systemUiStateFlags, boolean forceUpdate) { - if (!canShowNavButtons()) { + if (!isThreeButtonNav()) { return; } mControllers.navbarButtonsViewController.updateStateForSysuiFlags( diff --git a/quickstep/src/com/android/launcher3/taskbar/TaskbarControllers.java b/quickstep/src/com/android/launcher3/taskbar/TaskbarControllers.java index 157053efdd..c48c28b9e5 100644 --- a/quickstep/src/com/android/launcher3/taskbar/TaskbarControllers.java +++ b/quickstep/src/com/android/launcher3/taskbar/TaskbarControllers.java @@ -61,7 +61,7 @@ public class TaskbarControllers { */ public void init() { navbarButtonsViewController.init(this); - if (taskbarActivityContext.canShowNavButtons()) { + if (taskbarActivityContext.isThreeButtonNav()) { rotationButtonController.init(); } taskbarDragLayerController.init(this); diff --git a/quickstep/src/com/android/launcher3/taskbar/TaskbarDragLayerController.java b/quickstep/src/com/android/launcher3/taskbar/TaskbarDragLayerController.java index 743619b6be..db5c387770 100644 --- a/quickstep/src/com/android/launcher3/taskbar/TaskbarDragLayerController.java +++ b/quickstep/src/com/android/launcher3/taskbar/TaskbarDragLayerController.java @@ -93,7 +93,7 @@ public class TaskbarDragLayerController { */ public void updateInsetsTouchability(InsetsInfo insetsInfo) { insetsInfo.touchableRegion.setEmpty(); - if (mActivity.canShowNavButtons()) { + if (mActivity.isThreeButtonNav()) { // Always have nav buttons be touchable mControllers.navbarButtonsViewController.addVisibleButtonsRegion( mTaskbarDragLayer, insetsInfo.touchableRegion); diff --git a/quickstep/src/com/android/launcher3/taskbar/TaskbarKeyguardController.java b/quickstep/src/com/android/launcher3/taskbar/TaskbarKeyguardController.java index b7799d8149..2936bd2146 100644 --- a/quickstep/src/com/android/launcher3/taskbar/TaskbarKeyguardController.java +++ b/quickstep/src/com/android/launcher3/taskbar/TaskbarKeyguardController.java @@ -57,7 +57,7 @@ public class TaskbarKeyguardController { mKeyguardSysuiFlags = interestingKeyguardFlags; mBouncerShowing = bouncerShowing; - if (!mContext.canShowNavButtons()) { + if (!mContext.isThreeButtonNav()) { // For gesture nav we don't need to deal with bouncer or showing taskbar when locked return; }