From 36cc09b07b19198f4ea886583cef462ade27192c Mon Sep 17 00:00:00 2001 From: Adam Cohen Date: Thu, 29 Sep 2011 17:33:15 -0700 Subject: [PATCH] Fixing issue with cancelled drag blocking cell spaces (Issue 5386523) Change-Id: I9cfc728edeeee2237c21935517107e7a2af49646 --- src/com/android/launcher2/DragController.java | 1 + src/com/android/launcher2/DropTarget.java | 3 +++ src/com/android/launcher2/Workspace.java | 3 +++ 3 files changed, 7 insertions(+) diff --git a/src/com/android/launcher2/DragController.java b/src/com/android/launcher2/DragController.java index afbf80d17d..ca7e55b648 100644 --- a/src/com/android/launcher2/DragController.java +++ b/src/com/android/launcher2/DragController.java @@ -361,6 +361,7 @@ public class DragController { if (mLastDropTarget != null) { mLastDropTarget.onDragExit(mDragObject); } + mDragObject.cancelled = true; mDragObject.dragComplete = true; mDragObject.dragSource.onDropCompleted(null, mDragObject, false); } diff --git a/src/com/android/launcher2/DropTarget.java b/src/com/android/launcher2/DropTarget.java index 34fa893164..4172da2439 100644 --- a/src/com/android/launcher2/DropTarget.java +++ b/src/com/android/launcher2/DropTarget.java @@ -52,6 +52,9 @@ public interface DropTarget { /** Post drag animation runnable */ public Runnable postAnimationRunnable = null; + /** Indicates that the drag operation was cancelled */ + public boolean cancelled = false; + public DragObject() { } } diff --git a/src/com/android/launcher2/Workspace.java b/src/com/android/launcher2/Workspace.java index 44c533b950..873c03841b 100644 --- a/src/com/android/launcher2/Workspace.java +++ b/src/com/android/launcher2/Workspace.java @@ -3051,6 +3051,9 @@ public class Workspace extends SmoothPagedView } cellLayout.onDropChild(mDragInfo.cell); } + if (d.cancelled && mDragInfo.cell != null) { + mDragInfo.cell.setVisibility(VISIBLE); + } mDragOutline = null; mDragInfo = null; }