diff --git a/src/com/android/launcher3/allapps/search/AllAppsSearchBarController.java b/src/com/android/launcher3/allapps/search/AllAppsSearchBarController.java index 09344c8c0f..fd8945a0f6 100644 --- a/src/com/android/launcher3/allapps/search/AllAppsSearchBarController.java +++ b/src/com/android/launcher3/allapps/search/AllAppsSearchBarController.java @@ -100,14 +100,12 @@ public class AllAppsSearchBarController @Override public void afterTextChanged(final Editable s) { mQuery = s.toString(); - mInput.getSelectionStart(); if (mQuery.isEmpty()) { mSearchAlgorithm.cancel(true); mCallback.clearSearchResult(); } else { mSearchAlgorithm.cancel(false); - mSearchAlgorithm.doSearch(mQuery, mInput.getSelectionStart(), mTextConversions, - mCallback); + mSearchAlgorithm.doSearch(mQuery, mTextConversions, mCallback); } } @@ -117,7 +115,7 @@ public class AllAppsSearchBarController } // If play store continues auto updating an app, we want to show partial result. mSearchAlgorithm.cancel(false); - mSearchAlgorithm.doSearch(mQuery, mInput.getSelectionStart(), mCallback); + mSearchAlgorithm.doSearch(mQuery, mCallback); } @Override diff --git a/src/com/android/launcher3/allapps/search/DefaultAppSearchAlgorithm.java b/src/com/android/launcher3/allapps/search/DefaultAppSearchAlgorithm.java index 62b7807b66..222c8fea47 100644 --- a/src/com/android/launcher3/allapps/search/DefaultAppSearchAlgorithm.java +++ b/src/com/android/launcher3/allapps/search/DefaultAppSearchAlgorithm.java @@ -58,7 +58,7 @@ public class DefaultAppSearchAlgorithm implements SearchAlgorithm { } @Override - public void doSearch(String query, int cursorLocation, SearchCallback callback) { + public void doSearch(String query, SearchCallback callback) { mAppState.getModel().enqueueModelUpdateTask(new BaseModelUpdateTask() { @Override public void execute(LauncherAppState app, BgDataModel dataModel, AllAppsList apps) { diff --git a/src/com/android/launcher3/search/SearchAlgorithm.java b/src/com/android/launcher3/search/SearchAlgorithm.java index 8d85021fd4..96a15f4912 100644 --- a/src/com/android/launcher3/search/SearchAlgorithm.java +++ b/src/com/android/launcher3/search/SearchAlgorithm.java @@ -25,14 +25,13 @@ public interface SearchAlgorithm { /** * Performs search and sends the result to {@link SearchCallback}. */ - void doSearch(String query, int cursorLocation, SearchCallback callback); + void doSearch(String query, SearchCallback callback); /** * Performs search with {@code query} and the {@code suggestedQueries}/ */ - default void doSearch(String query, int cursorLocation, String[] suggestedQueries, - SearchCallback callback) { - doSearch(query, cursorLocation, callback); + default void doSearch(String query, String[] suggestedQueries, SearchCallback callback) { + doSearch(query, callback); } /** diff --git a/src/com/android/launcher3/widget/picker/search/SimpleWidgetsSearchAlgorithm.java b/src/com/android/launcher3/widget/picker/search/SimpleWidgetsSearchAlgorithm.java index 1e58154ee1..9be3b5f1e4 100644 --- a/src/com/android/launcher3/widget/picker/search/SimpleWidgetsSearchAlgorithm.java +++ b/src/com/android/launcher3/widget/picker/search/SimpleWidgetsSearchAlgorithm.java @@ -48,8 +48,7 @@ public final class SimpleWidgetsSearchAlgorithm implements SearchAlgorithm callback) { + public void doSearch(String query, SearchCallback callback) { ArrayList result = getFilteredWidgets(mDataProvider, query); mResultHandler.post(() -> callback.onSearchResult(query, result)); } diff --git a/src/com/android/launcher3/widget/picker/search/WidgetsSearchBarController.java b/src/com/android/launcher3/widget/picker/search/WidgetsSearchBarController.java index 35a2dbd0cb..2751a52796 100644 --- a/src/com/android/launcher3/widget/picker/search/WidgetsSearchBarController.java +++ b/src/com/android/launcher3/widget/picker/search/WidgetsSearchBarController.java @@ -71,7 +71,7 @@ public class WidgetsSearchBarController implements TextWatcher, } else { mSearchAlgorithm.cancel(/* interruptActiveRequests= */ false); mSearchModeListener.enterSearchMode(); - mSearchAlgorithm.doSearch(mQuery, mInput.getSelectionStart(), this); + mSearchAlgorithm.doSearch(mQuery, this); mCancelButton.setVisibility(VISIBLE); } } diff --git a/tests/src/com/android/launcher3/widget/picker/search/SimpleWidgetsSearchAlgorithmTest.java b/tests/src/com/android/launcher3/widget/picker/search/SimpleWidgetsSearchAlgorithmTest.java index 945c992a0a..d812ab012e 100644 --- a/tests/src/com/android/launcher3/widget/picker/search/SimpleWidgetsSearchAlgorithmTest.java +++ b/tests/src/com/android/launcher3/widget/picker/search/SimpleWidgetsSearchAlgorithmTest.java @@ -163,7 +163,7 @@ public class SimpleWidgetsSearchAlgorithmTest { mCameraContentEntry, mClockHeaderEntry, mClockContentEntry)) .when(mDataProvider) .getAllWidgets(); - mSimpleWidgetsSearchAlgorithm.doSearch("Ca", 2, mSearchCallback); + mSimpleWidgetsSearchAlgorithm.doSearch("Ca", mSearchCallback); MAIN_EXECUTOR.submit(() -> { }).get(); verify(mSearchCallback).onSearchResult( matches("Ca"), argThat(a -> a != null && !a.isEmpty())); diff --git a/tests/src/com/android/launcher3/widget/picker/search/WidgetsSearchBarControllerTest.java b/tests/src/com/android/launcher3/widget/picker/search/WidgetsSearchBarControllerTest.java index cff601ed1c..583d37fe0d 100644 --- a/tests/src/com/android/launcher3/widget/picker/search/WidgetsSearchBarControllerTest.java +++ b/tests/src/com/android/launcher3/widget/picker/search/WidgetsSearchBarControllerTest.java @@ -86,7 +86,7 @@ public class WidgetsSearchBarControllerTest { public void afterTextChanged_shouldDoSearch() { mEditText.setText("abc"); - verify(mSearchAlgorithm).doSearch(eq("abc"), 3, any()); + verify(mSearchAlgorithm).doSearch(eq("abc"), any()); } @Test