Use View.generateViewId if available

Bug: 17456181
Change-Id: Ib7e310ba38ed5e392c5c9b8734f197212f518389
This commit is contained in:
Ian Parkinson
2014-10-06 14:24:31 +01:00
parent 4b8d11fcb3
commit 0c2918f4f4

View File

@@ -689,19 +689,20 @@ public class Launcher extends Activity
}
}
/**
* Copied from View -- the View version of the method isn't called
* anywhere else in our process and only exists for API level 17+,
* so it's ok to keep our own version with no API requirement.
*/
public static int generateViewId() {
for (;;) {
final int result = sNextGeneratedId.get();
// aapt-generated IDs have the high byte nonzero; clamp to the range under that.
int newValue = result + 1;
if (newValue > 0x00FFFFFF) newValue = 1; // Roll over to 1, not 0.
if (sNextGeneratedId.compareAndSet(result, newValue)) {
return result;
if (Build.VERSION.SDK_INT >= 17) {
return View.generateViewId();
} else {
// View.generateViewId() is not available. The following fallback logic is a copy
// of its implementation.
for (;;) {
final int result = sNextGeneratedId.get();
// aapt-generated IDs have the high byte nonzero; clamp to the range under that.
int newValue = result + 1;
if (newValue > 0x00FFFFFF) newValue = 1; // Roll over to 1, not 0.
if (sNextGeneratedId.compareAndSet(result, newValue)) {
return result;
}
}
}
}