Merge "Ensuring that each CacheEntry has a default title and content description." into ub-launcher3-burnaby

This commit is contained in:
Winson Chung
2015-05-28 22:48:50 +00:00
committed by Android (Google) Code Review

View File

@@ -73,8 +73,8 @@ public class IconCache {
@Thunk static class CacheEntry {
public Bitmap icon;
public CharSequence title;
public CharSequence contentDescription;
public CharSequence title = "";
public CharSequence contentDescription = "";
public boolean isLowResIcon;
}
@@ -575,7 +575,7 @@ public class IconCache {
CacheEntry entry = mCache.get(cacheKey);
if (entry == null || (entry.isLowResIcon && !useLowResIcon)) {
entry = new CacheEntry();
mCache.put(cacheKey, entry);
boolean entryUpdated = true;
// Check the DB first.
if (!getEntryFromDB(cn, user, entry, useLowResIcon)) {
@@ -600,8 +600,14 @@ public class IconCache {
} catch (NameNotFoundException e) {
if (DEBUG) Log.d(TAG, "Application not installed " + packageName);
entryUpdated = false;
}
}
// Only add a filled-out entry to the cache
if (entryUpdated) {
mCache.put(cacheKey, entry);
}
}
return entry;
}