From b4f899fd9a7809fac63c25c2ef4f976068e35f7b Mon Sep 17 00:00:00 2001 From: Lucas Dupin Date: Thu, 26 Aug 2021 22:24:18 +0000 Subject: [PATCH] Don't avoid blurring overview The app window is now on top of the scrims, so we can just mark the window as opaque and keep blurring. Bug: 196828055 Test: atest OutputUpdateAndWriteCompositionStateTest Test: systrace on all app, and overview Change-Id: I128d3b4722060c0bb72a218bf01ba26dabaddacf --- .../android/launcher3/statehandlers/DepthController.java | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/quickstep/src/com/android/launcher3/statehandlers/DepthController.java b/quickstep/src/com/android/launcher3/statehandlers/DepthController.java index 68159fafdd..ab88b2b218 100644 --- a/quickstep/src/com/android/launcher3/statehandlers/DepthController.java +++ b/quickstep/src/com/android/launcher3/statehandlers/DepthController.java @@ -296,13 +296,10 @@ public class DepthController implements StateHandler, } if (supportsBlur) { - // We cannot mark the window as opaque in overview because there will be an app window - // below the launcher layer, and we need to draw it -- without blurs. - boolean isOverview = mLauncher.isInState(LauncherState.OVERVIEW); - boolean opaque = mLauncher.getScrimView().isFullyOpaque() && !isOverview; + boolean opaque = mLauncher.getScrimView().isFullyOpaque(); - int blur = opaque || isOverview || !mCrossWindowBlursEnabled - || mBlurDisabledForAppLaunch ? 0 : (int) (depth * mMaxBlurRadius); + int blur = !mCrossWindowBlursEnabled || mBlurDisabledForAppLaunch + ? 0 : (int) (depth * mMaxBlurRadius); SurfaceControl.Transaction transaction = new SurfaceControl.Transaction() .setBackgroundBlurRadius(mSurface, blur) .setOpaque(mSurface, opaque);